TNM 10b closing unexpectedly

[unright]

When I change a wrestler's name within a circuit, the program shuts down.

[tnmlyger]

Would that be on the same screen where you hire wrestlers?

Please ZIP up your TNM folder and send it to [e-mail] via WeTransfer.com or another file transfer service. I'll have a look and will let you know how to fix it.

[unright]

Actually I looked it further because I wanted to give you more detail and I think I found the issue. It seems to be a very hyper-specific glitch.

It only happens in one specific circuit to one specific wrestler and with only one specific name change.

I wanted to change Albert's name to Prince Albert, but I think the circuit closes because at some point in the past I had used the Circuit Editor to change Albert to Prince Albert in a result (other cards still have regular Albert). That's probably the reason it crashes.

I don't really need a fix as it's not really a super important thing I need (I can just leave him as Albert). I guess I just wanted to make you aware of it. If you still want me to send a zip in, let me know.

[tnmlyger]

Awesome detective work, sir :-)

If you were so kind to please send the ZIP anyway, I could figure out a way to help you... and by extension help the next person who will change Albert's name to Prince Albert in about... say... 23 years :-D

Thanks in advance!

[unright]

Hey now. I may have stopped watching wrestling in the summer of 1999, but I'm sure that Albert and his revolutionary gimmick of being a wrestling body piercer went on to become a main event talent. There's no better possible gimmick for someone of Matt Bloom's ability.

[...]

I'll send it in.

[tnmlyger]

Hahaha - thank you :-)

It was as I suspected.

When you rename a wrestler, you are given the option of renaming him in the ratings as well.

When you tell it to do that, it goes through each of the ratings files and replaces the wrestler's old name with the wrestler's new name.

Believe it or not but you've discovered a bug that had been sitting there since 1997 that would only hit if you replaced a wrestler's name with a name that added something in the beginning but otherwise kept the old name (e.g. "Albert" -> "Prince Albert").

Because string operations under DOS can sometimes fail when you're close to running out of free memory (code and data have to get by with <500kB total), I hardened TNM against that by checking after the replace operation whether the old name was still present. And if that was the case, it would retry.

I think you can see where I'm going with this.

So this is what happened:

Albert -> Prince Albert
Prince Albert -> Prince Prince Albert
Prince Prince Albert -> Prince Prince Prince Albert
...

... until it ran out of memory and threw an error.

I hadn't thought of this particular case at the time.

Please download this: www.tnm7.de/downloads/cardhir.zip

Then please unzip it to TNM7SE\TNM7SE\PROGRAM and have it replace the existing CARDHIR.PBC. That'll fix the issue.

[unright]

Ah, thanks Oliver. It's working fine. Though now I'm tempted to rename him "Prince Prince Prince Albert" and have him in a round robin feud with Prince Nana, Prince Iaukea, and Prince Devitt.

Or maybe it's a stable waiting to happen....

[tnmlyger]

Awesome to hear - thank you :-)

I find it amazing that you were able to find a bug that had been undiscovered for 22 years - LOL

Don't forget the Prince of Bel Air, Freddy Prinze and Leslie Barbara's dog Princess from Police Academy who - according to Commandant Lassard - is clearly a Prince.